Fix: stop counting non-Basic auth schemes and malformed tokens as failed attempts#7
Merged
joelbyford merged 2 commits intoSecurityUpdatesfrom Mar 5, 2026
Merged
Conversation
…ions Co-authored-by: joelbyford <57726719+joelbyford@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on security enhancements implementation
Fix: stop counting non-Basic auth schemes and malformed tokens as failed attempts
Mar 5, 2026
joelbyford
approved these changes
Mar 5, 2026
Owner
joelbyford
left a comment
There was a problem hiding this comment.
Validated in local test environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invokewas incrementing the IP failure counter whenever anyAuthorizationheader was present but unparseable as Basic credentials — includingBearertokens and other schemes — unintentionally triggering lockouts for clients not attempting Basic Auth at all.Changes
TryGetCredentials: RemovedhadAuthorizationHeaderout parameter — it was the only driver of the incorrect failure pathInvoke: Removed theif (hadAuthorizationHeader) { RegisterFailedAttempt(...) }block; failed attempts now register only when credentials fully parse (validBasicscheme, decodable base64, extractableuser:pass) but are rejected byIsAuthorized💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.